Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

P2029R4 ("character escapes") seemingly attempts to introduce new terms #4394

Open
tkoeppe opened this issue Nov 27, 2020 · 4 comments · May be fixed by #6031
Open

P2029R4 ("character escapes") seemingly attempts to introduce new terms #4394

tkoeppe opened this issue Nov 27, 2020 · 4 comments · May be fixed by #6031

Comments

@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 27, 2020

The newly added table lex.ccon.literal from #4371/P2029R4 seems to attempt to define the terms "ordinary characater literal", "wide character literal", "UTF-8 character literal", etc., but the presentation makes this unclear. Usually, definitions appear in plain body text where the context and style makes it clear that a new term is being defined, but the table stands apart from the main text, and so we can no longer rely on this convention.

It seems useful to define the terms in the main text, e.g. by adding a sentence to the new paragraph 2:

"The kind of a character literal [...] as defined by Table Yas described by Table Y. The following kinds are defined: an ordinary character literal is ...".

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Nov 27, 2020

The "string literal" table also needs a similar treatment I think.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Nov 27, 2020

I'm also not entirely happy with how the character-literal Table Y uses three different rows for "ordinary","non-encodable","multi" literals, but then uses those same three rows for a single (rowspan=3) cell in the next column. This requires a little too much interpretation for my taste and should be styled more obviously.

@jensmaurer
Copy link
Member

This table needed a lot of work to make it narrow enough to fit and keeping the original spirit. I'm not sure what the options are for "styled more obviously". We could consider splitting into two tables, one associating the prefix with the simple term and the character set (one row per prefix) and other one for types and examples.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Nov 28, 2020

I was thinking horizontal rules to show cell boundaries, and/or a "}" brace for the rowspanned cell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants