Rebased version of CWG Poll 5: P1787R6 Declarations and where to find them #4398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpplearner
reviewed
Dec 1, 2020
tkoeppe
force-pushed
the
motions-2020-11-cwg-5-as_in_paper
branch
3 times, most recently
from
c0843b0
to
e55ec5d
Compare
This change includes modifications to preserve the effects of CWG motions 1 and 3, as well as several minor spelling fixes. Additional, larger editorial changes appear in subsequent commits.
tkoeppe
force-pushed
the
motions-2020-11-cwg-5-as_in_paper
branch
from
0d6c38b
to
00fa43b
Compare
opensdh
reviewed
Dec 11, 2020
| \pnum | ||
| In a friend declaration \grammarterm{declarator} | ||
| whose \grammarterm{declarator-id} is a \grammarterm{qualified-id} | ||
| whose lookup context is\iref{basic.lookup.qual} a class or namespace $S$, |
There was a problem hiding this comment.
This reproduces a mistake in cross-reference placement from the paper (sorry):
Suggested change
| whose lookup context is\iref{basic.lookup.qual} a class or namespace $S$, | |
| whose lookup context\iref{basic.lookup.qual} is a class or namespace $S$, |
There was a problem hiding this comment.
Ah, sorry, I missed that, will fix after merges!
There was a problem hiding this comment.
Fixed by 2432aca, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4326
Fixes cplusplus/papers#533
This is a rebase of #4379, which we retain as-is in order to preserve the comments.