Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[std] Move punctuation to before the footnote marker. #4402

Merged
merged 1 commit into from Dec 14, 2020
Merged

[std] Move punctuation to before the footnote marker. #4402

merged 1 commit into from Dec 14, 2020

Conversation

jensmaurer
Copy link
Member

Also add an automated check.

Fixes #4400

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 3, 2020

Thanks a lot, Jens! Let's wait for the motions to merge, and touch this up if necessary, and then this will go in first thing.

@tkoeppe tkoeppe added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Dec 14, 2020
@tkoeppe tkoeppe added this to the post-2020-11 milestone Dec 14, 2020
@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Dec 14, 2020
@jensmaurer
Copy link
Member Author

Uh, this still needs some fixes for newly-introduced violations caught by check.sh.

@tkoeppe
Copy link
Contributor

tkoeppe commented Dec 14, 2020

Thanks, Jens! I'm very glad we're getting this change!

@jensmaurer
Copy link
Member Author

Ok, all fixed, ready to merge.

@tkoeppe tkoeppe merged commit 3b4b8d3 into cplusplus:master Dec 14, 2020
@jensmaurer jensmaurer deleted the c13 branch December 14, 2020 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2020-11
Development

Successfully merging this pull request may close these issues.

Footnote marks should appear after punctuation
2 participants
@jensmaurer @tkoeppe