[cpp.import] Clarify header units as the source of macro definitions. #4406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensmaurer
force-pushed
the
c16
branch
2 times, most recently
from
bfece19
to
933995f
Compare
|
@zygoloid: could you kindly review this? |
zygoloid
approved these changes
Dec 14, 2020
| denoted by the \grammarterm{header-name}. | ||
| denoted by the \grammarterm{header-name}, | ||
| as described below. | ||
| \end{note} | ||
| \indextext{point of!macro import|see{macro, point of import}}% | ||
| The \defnx{point of macro import}{macro!point of import} for the | ||
| first two forms of \grammarterm{pp-import} is |
There was a problem hiding this comment.
For completeness, should we say "The last form of pp-import is only considered if the first two forms did not match, and does not have a point of macro import." below?
| of macro import of a header unit containing a point of definition for the | ||
| macro definition, if any. | ||
| In the latter case, the macro is said | ||
| to be \defnx{imported}{macro!import} from the header unit. |
There was a problem hiding this comment.
I wonder if we can make this a little clearer by separating the two cases with bullets and moving the parenthesized text to the front:
The point of definition of a macro definition within a translation unit T is:
- if the
#definedirective of the macro definition occurs within T, the point at whichitsthat directive occurs#define(in the translation unit containing the, or otherwise,#definedirective)- if the macro name is not lexically identical to a keyword or to the identifiers
moduleorimport, the first point of macro import in T of atranslationheader unit containing a point of definition for the macro definition, if any.
tkoeppe
added
the
changes requested
jensmaurer
removed
the
changes requested
zygoloid
approved these changes
Mar 4, 2021
|
@tkoeppe, please merge per http://lists.isocpp.org/core/2021/03/10570.php |
|
Done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4404