[stmt.return], [stmt.return.coroutine] update notes re implicit move #4408
Conversation
|
This is mostly fixed with #3998, I believe. |
There was a problem hiding this comment.
Please make sure the commit description is properly formatted.
It should start with the [section.label] and then describe the change.
For this particular change, maybe it's less relevant that we changed two notes,
but more relevant that we now highlight implicitly movable entities.
Suggestion: "Fix and add notes about implicit moving in co_/return statements"
…tatements These notes probably should have been changed when P1825 was adopted.
Quuxplusone
force-pushed
the
implicit-move-notes
branch
from
1359db5
to
941ebcf
Compare
jensmaurer
added
the
changes requested
wg21bot
added
the
needs rebase
|
Please reopen (and rebase) if you'd like to continue working on this. |
Quuxplusone
changed the title
|
I'm not actually sure how to reopen; but I have rebased now (and updated the commit summary line). |
|
Oh, I see, the reopen button isn't working for me either. Odd. Did you "recreate" the branch? In that case maybe you could start a new pull request off that branch? |
|
Okay, opened #5783! |
These notes probably should have been changed when P1825 was adopted.
I'm not sure if this is editorial.
Also, I disagree with the use of the word "can" in the existing note; it seems to me that this is not a choice the user gets to make, and so this was an incorrect search-and-replace in e5455e3 — but maybe this is just ISO style now, I dunno.