Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[range.iota.iterator,range.iota.sentinel] Complete iota_view's requires-clause #4426

Merged
merged 1 commit into from Jan 15, 2021
Merged

[range.iota.iterator,range.iota.sentinel] Complete iota_view's requires-clause #4426

merged 1 commit into from Jan 15, 2021

Conversation

JohelEGP
Copy link
Contributor

Completes ae15dd1.

@tkoeppe
Copy link
Contributor

tkoeppe commented Jan 15, 2021

I appreciate this, but is this editorial? The LWG issue doesn't contain this change, what makes this an "obvious oversight"?

@jwakely: could you perhaps provide an LWG perspective on this PR?

jwakely
jwakely approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should have been part of the LWG issue. The extra constraint was added to the primary template, and so should also be present on the out-of-class definitions of the nested members of that class.

@tkoeppe
Copy link
Contributor

tkoeppe commented Jan 15, 2021

Thanks!

@tkoeppe tkoeppe merged commit 7b19715 into cplusplus:master Jan 15, 2021
@JohelEGP JohelEGP deleted the range.iota branch January 15, 2021 16:39
@CaseyCarter CaseyCarter mentioned this pull request Feb 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JohelEGP @tkoeppe @jwakely @jensmaurer