[localization] Reformat LaTeX source code. #4436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add two missing periods and remove one instance of superfluous whitespace.
JohelEGP
reviewed
Dec 27, 2020
| \item | ||
| For a \tcode{double} value, the function \tcode{strtod}. | ||
| \item | ||
| For a \tcode{long double} value, the function \tcode{strtold}. |
There was a problem hiding this comment.
Why not indent each \item text by 2 spaces as required, or just remove the original blank lines between items? Also for the lists below.
There was a problem hiding this comment.
I don't think we've made up our mind on \item source formatting just yet.
There was a problem hiding this comment.
@zygoloid was ultimately against formatting that was difficult to relocate or regroup, so I think we may be moving away from that rule.
JohelEGP
reviewed
Dec 27, 2020
| purely for efficiency. | ||
| An array of \tcode{char}, | ||
| rather than an array of \tcode{part}, | ||
| is specified for \tcode{pattern::field} purely for efficiency. | ||
| \end{footnote} |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
JohelEGP
reviewed
Dec 27, 2020
| component of the format | ||
| specified by a \tcode{pattern} value \tcode{p}, | ||
| such that the \tcode{part} value \tcode{static_cast<part>(p.field[i])} | ||
| determines the $\tcode{i}^\text{th}$ component of the format |
There was a problem hiding this comment.
Suggested change
| determines the $\tcode{i}^\text{th}$ component of the format | |
| determines the $\tcode{i}^\text{th}$ component of the format. |
JohelEGP
reviewed
Dec 27, 2020
Comment on lines
2311
to
2325
| The numeric value to be stored can be one of: | ||
| \begin{itemize} | ||
| \item zero, if the conversion function does not convert the entire field. | ||
|
|
||
| \item the most positive (or negative) representable value, | ||
| \item | ||
| zero, if the conversion function does not convert the entire field. | ||
| \item | ||
| the most positive (or negative) representable value, | ||
| if the field to be converted to a signed integer type represents a value | ||
| too large positive (or negative) to be represented in \tcode{val}. | ||
|
|
||
| \item the most positive representable value, | ||
| \item | ||
| the most positive representable value, | ||
| if the field to be converted to an unsigned integer type represents a value | ||
| that cannot be represented in \tcode{val}. | ||
|
|
||
| \item the converted value, otherwise. | ||
| \item | ||
| the converted value, otherwise. | ||
| \end{itemize} |
There was a problem hiding this comment.
The capitalization here needs fixing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add two missing periods and remove one instance
of superfluous whitespace.