[stacktrace.basic.cmp] Update 'lexicographical_compare_3way' #4473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The name has been changed to 'lexicographical_compare_three_way' by P1614R2.
jensmaurer
requested changes
Jan 26, 2021
source/utilities.tex
Outdated
| @@ -21723,7 +21723,7 @@ | |||
| \pnum | |||
| \returns | |||
| \tcode{x.size() <=> y.size()} if \tcode{x.size() != y.size()}; | |||
| \tcode{lexicographical_compare_3way(\newline | |||
| \tcode{lexicographical_compare_three_way(\newline | |||
There was a problem hiding this comment.
The manual \newline needs to go, otherwise we get a bad line break.
Suggested change
| \tcode{lexicographical_compare_three_way(\newline | |
| \tcode{lexicographical_compare_three_way( |
There was a problem hiding this comment.
Did you actually build the PDF with that change? Now there is an extra space after the (, so some more fixes are in order.
Further, your name shows up as
Author: lam-work-group <77063444+lam-work-group@users.noreply.github.com>
in the resulting git history. Is that how you wish to be cited?
|
See #4474 for the fixed pull request. |
|
This was fixed by #4474. Thanks for bringing this up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name has been changed to
lexicographical_compare_three_wayby P1614R2.