New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[iterator.concept.winc] Move concept definition near its description #4487
base: main
Are you sure you want to change the base?
Conversation
@tkoeppe , rebased and force-pushed. |
requires @\exposid{is-signed-integer-like}@<iter_difference_t<I>>; | ||
{ ++i } -> @\libconcept{same_as}@<I&>; // not required to be equality-preserving | ||
i++; // not required to be equality-preserving | ||
}; | ||
\end{codeblock} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, it's a bit weird to have these "bare" codeblocks, which in reality are stuck to their preceding paragraph. The status quo was sort of OK, but the new codeblock you're now introducing below seems to be stuck to the wrong paragraph now. We're lacking a mechanism to introduce something with an unnumbered block at the beginning. We have that for synopses and for grammar, and I suppose for itemdecls, but this use case is none of these. Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, I wouldn't mind if all of these concept definitions were changed to use itemdecl
instead of codeblock
. I'm not sure how we landed on codeblock
in the first place; I suspect it was a typo on my part the first time that was then replicated a couple of dozen times.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased. I've also moved the \pnum
to before the codeblock.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been adding subclause structures whenever we had more such "bare" codeblocks (of which recent papers added a lot), but maybe itemdecls are the way to go here. In any case, I'm afraid this needs another rebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jensmaurer would you like to take another stab at this?
These types are used in the specification of the exposition-only concepts is-integer-like and is-signed-integer-like. The rename avoids a presentation conflict with the placeholder type I referring to an iterator type.
Also rename the placeholder type I to T, used in the specification
of the exposition-only concepts is-integer-like and
is-signed-integer-like, to avoid a presentation conflict
with the placeholder type I referring to an iterator type.
Fixes #4472