Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cmp.alg] Clarify ill-formed CPO invocations are SFINAE-friendly #4494

Merged
merged 1 commit into from Mar 15, 2021
Merged

[cmp.alg] Clarify ill-formed CPO invocations are SFINAE-friendly #4494

merged 1 commit into from Mar 15, 2021

Conversation

jensmaurer
Copy link
Member

Fixes #4492

@jensmaurer jensmaurer requested review from jwakely and CaseyCarter and removed request for jwakely February 12, 2021 20:01
@tkoeppe
Copy link
Contributor

tkoeppe commented Feb 15, 2021

Looks good, but I'll wait for approval from @jwakely and @CaseyCarter. Thank you!

CaseyCarter
CaseyCarter approved these changes Feb 16, 2021
View reviewed changes
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! +1 to removing the unconventional std:: qualifications, and I agree that it's better to strike "Diagnosable" from the notes for these CPOs with no IFNDR cases than to keep the notes consistent with the notes for the range access CPOs.

@jensmaurer
Copy link
Member Author

@tkoeppe , approvals have arrived.

@tkoeppe tkoeppe merged commit ce0db1e into cplusplus:master Mar 15, 2021
@jensmaurer jensmaurer deleted the c31 branch March 15, 2021 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@jwakely jwakely jwakely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cmp.alg] Notes for ill-formed cases are inconsistent with those in [range.access]
4 participants
@jensmaurer @tkoeppe @CaseyCarter @jwakely