Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vector.bool] Remove an extra close-paren. #4501

Merged
merged 1 commit into from Feb 22, 2021

Conversation

Quuxplusone
Copy link
Contributor

In this vicinity I also noticed:

  • The copy-constructor and assignment-operators for both flavors of vector give the rhs argument the name "x", which seems a bit silly; it could go unnamed if we wanted.

  • vector<bool>'s move-constructor is not declared noexcept. This was deliberate; I don't really know why, though. N4258 made vector<T>'s move-ctor noexcept, and says briefly at the bottom: "No change in vector" (no rationale).

  • The sequence containers and set declare constructors taking initializer_list<T>, whereas the maps and unordered_{multi,}set declare constructors taking initializer_list<value_type>. (This is almost entirely consistent with the hypothesis that for simplicity we use T wherever it's synonymous with value_type; except that unordered_{multi,}set breaks that rule.)

@jensmaurer jensmaurer merged commit 70da127 into cplusplus:master Feb 22, 2021
@jensmaurer
Copy link
Member

  • Removing the parameter name of copy operations is fine, I think.
  • Changing the noexcept status of a move constructor is non-editorial; please file an LWG issue.
  • taking aT instead of value_type seems editorial.

Feel free to post additional pull requests for the editorial fixes.

@Quuxplusone Quuxplusone deleted the vector-bool-typos branch May 26, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants