Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdatomic.h.syn] Add semicolons in using statements. #4502

Merged
merged 2 commits into from Feb 22, 2021
Merged

[stdatomic.h.syn] Add semicolons in using statements. #4502

merged 2 commits into from Feb 22, 2021

Conversation

mkurdej
Copy link
Contributor

@mkurdej mkurdej commented Feb 22, 2021

No description provided.

jwakely
jwakely requested changes Feb 22, 2021
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. The semi-colons are present in http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2020/p0943r6.html and their omission from the draft is an editorial error.

As per https://github.com/cplusplus/draft/wiki/Specification-Style-Guidelines#code-blocks the // see below comments are meant to line up on a specific column, so you should remove a space when adding the ; character.

@mkurdej
Copy link
Contributor Author

mkurdej commented Feb 22, 2021

OK. I'll line up the // see below comments as needed.

jwakely
jwakely approved these changes Feb 22, 2021
View reviewed changes
Copy link
Member

@jwakely jwakely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jensmaurer jensmaurer merged commit 825255f into cplusplus:master Feb 22, 2021
@mkurdej mkurdej deleted the stdatomic-semicolons branch February 22, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mkurdej @jwakely @jensmaurer