Make checker script more helpful #4530
Conversation
jwakely
changed the title
tools/check.sh
Outdated
| # Filter that exits the process if its input is non-empty. | ||
| # If $* args given, prefixes each line of input with "Error: $*: ". | ||
| fail() { | ||
| awk -v str="$*" '/./ { if (length(str)) { print "Error: " str ": " $0 } x=1 } EXIT { exit x }' |
There was a problem hiding this comment.
This doesn't exit the surrounding shell, it just exits the awk script. Thus, this changes the status quo. But maybe we want all checks run, and not terminate after the first error.
But the general idea is nice. We should mix it with the "github action log commands" so that the errors are categorized as such, and colored red. Give me a little while.
There was a problem hiding this comment.
Oops, I lost the || exit 1 when changing it from a sed command (as demo'd at #4529 (comment)) to an awk one.
The idea was that the awk script keeps processing all input lines, but exits with non-zero status if the input wasn't empty. I think awk '... EXIT { exit NR }' || exit would also work.
There was a problem hiding this comment.
Oops, but it needs to be END not EXIT
There was a problem hiding this comment.
And it still won't work, because it exits the process at the end of the pipeline, which doesn't exit the process running the script. We need set -e to make it exit the whole script.
jwakely
force-pushed
the
linter
branch
2 times, most recently
from
46de0d9
to
ad6c768
Compare
|
It should work better now. |
|
Superseded by #4533 |
Fixes #4529