Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[concepts] rotates [concept.swappable] to the end of [concepts.lang] #4535

Closed
wants to merge 1 commit into from
Closed

[concepts] rotates [concept.swappable] to the end of [concepts.lang] #4535

wants to merge 1 commit into from

Conversation

cjdb
Copy link
Contributor

@cjdb cjdb commented Mar 1, 2021

ranges::swap depends on assignable_from and move_constructible, so
it should be defined after them.

`ranges::swap` depends on `assignable_from` and `move_constructible`, so
it should be defined after them.
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. (Painstakingly verified that the red and green text all matches.)

@tkoeppe tkoeppe added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Mar 15, 2021
@jensmaurer
Copy link
Member

@cjdb , please rebase.

@cjdb
Copy link
Contributor Author

cjdb commented Apr 1, 2021

Ack, will apply tonight.

@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 24, 2021

@cjdb: continue rebasing?

@tkoeppe
Copy link
Contributor

tkoeppe commented Aug 22, 2022

@cjdb: keep rebasing -- you're almost there!

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 16, 2022

Noooo!

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 16, 2022

@jensmaurer Shall we reapply this? Looks like a simple move.

@jensmaurer
Copy link
Member

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase The pull request needs a git rebase to resolve merge conflicts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants