[time.syn] add constexpr to leap_second comparisons #4539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwakely
approved these changes
Mar 7, 2021
jensmaurer
approved these changes
Mar 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comparison operators for
leap_secondare all specified as beingconstexprin [time.zone.leap.nonmembers], but this specifier is missing in the corresponding section of [time.syn]. Although the current wording matches P0355R7, I think this could qualify as an editorial issue. It's internally inconsistent and the intent seems clear, especially because these functions just call the correspondingtime_pointoverrides, which areconstexprin both places. I'm happy to submit an LWG issue, however, if you feel differently.