Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[basic.stc.static] Rephrase the definition of 'static storage duration' #4575

Merged
merged 1 commit into from Jun 17, 2021

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer commented Apr 2, 2021

This clarifies and centralizes the definition and
also avoids the undefined term 'local variable'.

Fixes #4567

@tkoeppe
Copy link
Contributor

tkoeppe commented Apr 30, 2021

(To review by group, but tentatively OK to merge.)

@tkoeppe
Copy link
Contributor

tkoeppe commented Apr 30, 2021

To be reworded, it's too obscure at the moment that static block variables are handled elsewhere.

@jensmaurer
Copy link
Member Author

Editorial meeting 2021-04-30: Make sure this definition is complete (considers static local variables as well). Also reword p3.

@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Apr 30, 2021
@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label May 1, 2021
@jensmaurer jensmaurer requested a review from tkoeppe May 1, 2021 21:32
@jensmaurer jensmaurer changed the title [basic.stc.static] Avoid the undefined term 'local variable' [basic.stc.static] Rephrase the definition of 'static storage duration' May 1, 2021
@jensmaurer jensmaurer requested a review from zygoloid May 2, 2021 07:59
@tkoeppe
Copy link
Contributor

tkoeppe commented May 2, 2021

@zygoloid: your review would be most appreciated here.

source/basic.tex Outdated Show resolved Hide resolved
source/basic.tex Outdated
do not have thread storage duration and
\item
belong to a namespace scope\iref{basic.scope.namespace} or
are declared with
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be useful to say "are first declared" here, given that static is inherited in redeclarations (and can't be present in a redeclaration of a class member)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that clarifies the "class member redeclaration" case.

Fixed

This clarifies and centralizes the definition and
also avoids the undefined term 'local variable'.
@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 17, 2021

Looks good, I'll merge this.

@tkoeppe tkoeppe merged commit d3fbad1 into cplusplus:master Jun 17, 2021
@jensmaurer jensmaurer deleted the c29 branch June 17, 2021 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The non-normative wording "local variable" should not survive in [basic.stc.static]
3 participants