Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[syserr] Should make_error_code and make_error_condition be found by ADL? LWG3629 #4577

Closed
cpplearner opened this issue Apr 5, 2021 · 3 comments · Fixed by #5983
Closed

[syserr] Should make_error_code and make_error_condition be found by ADL? LWG3629 #4577

cpplearner opened this issue Apr 5, 2021 · 3 comments · Fixed by #5983
Labels
lwg Issue must be reviewed by LWG. not-editorial Issue is not deemed editorial; the editorial issue is kept open for tracking.

Comments

@cpplearner
Copy link
Contributor

[syserr.errcode.constructors]/4 and [syserr.errcode.modifiers]/3 have a postcondition:

Postconditions: *this == make_error_code(e).

Similarly, [syserr.errcondition.constructors]/4 and [syserr.errcondition.modifiers]/3 have a postcondition:

Postconditions: *this == make_error_condition(e).

Per [contents]/3 these should be treated as qualified calls. But all implementations (MSVC, libstdc++, libc++, Boost) use unqualified call.

I believe that the intent is to find program-defined make_error_code and make_error_condition. That is, the specification should clarify that these functions are found by ADL.
@jensmaurer
Copy link
Member

jensmaurer commented Apr 5, 2021 •
edited

Yes, I believe make_error_code() and make_error_condition() were intended as customization points.

@jwakely, this sounds like an LWG issue to me. In particular, any mention of argument-dependent name lookup should probably discuss in which context it is performed.

@jwakely
Copy link
Member

jwakely commented Apr 5, 2021 •
edited by jensmaurer

Yes, this needs an LWG issue.

LWG3629

@jensmaurer jensmaurer added lwg Issue must be reviewed by LWG. not-editorial Issue is not deemed editorial; the editorial issue is kept open for tracking. labels Apr 5, 2021
@trueqbit trueqbit mentioned this issue Mar 5, 2022
Closed
@frederick-vs-ja
Copy link
Contributor

This should have been fixed by #5983 (72afe68).

@jensmaurer jensmaurer mentioned this issue May 10, 2023
Merged
@jensmaurer jensmaurer changed the title [syserr] Should make_error_code and make_error_condition be found by ADL? [syserr] Should make_error_code and make_error_condition be found by ADL? LWG3629 Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lwg Issue must be reviewed by LWG. not-editorial Issue is not deemed editorial; the editorial issue is kept open for tracking.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Motions 2022 11 lwg 7] P2703R0 C++ Standard Library Ready Issues cplusplus/draft
4 participants
@jwakely @cpplearner @frederick-vs-ja @jensmaurer