P2351: add [[nodiscard]] to cast-like library wrappers [WIP] #4579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…except, as_const, to_underlying, and identity::operator()
hanickadot
changed the title
|
Which part is "WIP" here? |
jensmaurer
added
the
decision-required
|
Paper is WIP. LEWG is discussing if the paper is worth of spending time on it. My idea is to have an open pull request as part of the paper. If that's not what you want here close it. |
|
@tkoeppe, please state whether you consider the change here editorial. |
|
No, I don't think this is editorial (as much I would like to). I want guidance from LEWG/LWG too. But I also like the idea that the paper is accompanied with an open pull request to the draft. To make it easier for editors. |
jensmaurer
added
lwg
wg21bot
added
the
needs rebase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bit_cast, to_integer, forward, move, move_if_noexcept, as_const, to_underlying, and identity::operator()