Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[range.utility.helpers] not-same-as is confusingly named #4606

Closed
timsong-cpp opened this issue May 20, 2021 · 3 comments · Fixed by #4623
Closed

[range.utility.helpers] not-same-as is confusingly named #4606

timsong-cpp opened this issue May 20, 2021 · 3 comments · Fixed by #4623
Assignees
@jensmaurer

Comments

@timsong-cpp
Copy link
Contributor 

template<class T, class U>
  concept not-same-as =                         // exposition only
    !same_­as<remove_cvref_t<T>, remove_cvref_t<U>>;

It's confusing to have not-same-as<T, U> mean something completely different from not same_as<T, U>. Can we find a better name for this exposition-only concept?
@jensmaurer
Copy link
Member

  • It's not "completely" different, it's just a bit different.
  • Suggestions for a better name are welcome.

@jwakely
Copy link
Member

jwakely commented May 20, 2021

dissimilar ?

@timsong-cpp
Copy link
Contributor Author

I think we should avoid "similar" since that's a Core term. P2199 wants to propose this exact thing as different_from (R0 uses distinct_from but a change is expected in the next revision), so maybe we can just call it different-from?

@jensmaurer jensmaurer self-assigned this Jun 3, 2021
@jensmaurer jensmaurer mentioned this issue Jun 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ranges] Rename 'not-same-as' to 'different-from'. jensmaurer/draft
3 participants
@jwakely @timsong-cpp @jensmaurer