Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vector.bool] reference has multiple assignment operators #4607

Merged
merged 1 commit into from May 21, 2021
Merged

[vector.bool] reference has multiple assignment operators #4607

merged 1 commit into from May 21, 2021

Conversation

CaseyCarter
Copy link
Contributor

No description provided.

@jensmaurer
Copy link
Member

jensmaurer commented May 21, 2021 •
edited

This depends on P2321 zip (Tim Song) cplusplus/papers#1003

@CaseyCarter
Copy link
Contributor Author

This depends on P2321 zip (Tim Song) cplusplus/papers#1003

I don't believe so; vector<bool>::reference currently has two assignment operators:

constexpr reference& operator=(const bool x) noexcept;
constexpr reference& operator=(const reference& x) noexcept;

So use of the singular "assignment operator" in the paragraph in question is incorrect. P2321 does add a third assignment operator, but that change is orthogonal to the fix in this PR.

@jensmaurer
Copy link
Member

Ah, right.

@tkoeppe tkoeppe merged commit 7789f70 into cplusplus:master May 21, 2021
@CaseyCarter CaseyCarter deleted the vbool branch May 21, 2021 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CaseyCarter @jensmaurer @tkoeppe