Consistency cleanups in [containers]: Whitespace #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7418,7 +7399,7 @@ | |||
| template <class InputIterator> void insert(InputIterator first, InputIterator last); | |||
| void insert(initializer_list<value_type>); | |||
|
|
|||
| iterator erase(const_iterator position); | |||
| iterator erase(const_iterator position); | |||
| size_type erase(const key_type& k); | |||
| iterator erase(const_iterator first, const_iterator last); | |||
There was a problem hiding this comment.
Shouldn't this third erase() overload be lined up too? It is for unordered_map::erase() but not the other unordered containers.
|
I'm sending a second commit to make erase/swap/clear and find/count more consistent. |
tkoeppe
force-pushed
the
consistency_fixes_1
branch
from
34a9cee
to
ee71f5d
Compare
…part of the cleanup changes only whitespace: inserted before commas, removed after namespace braces, improved indentation consistency, removed some extraneous linebreaks for things that fit well on one line
tkoeppe
force-pushed
the
consistency_fixes_1
branch
from
7bf6792
to
99c10db
Compare
|
Apart from one missing space on line 6375 it looks great, and that can be done in another commit if you don't want to update this branch again. @zygoloid, the only bit I have any hesitation about is removing some line breaks, creating longer lines. Is it safe to assume we're not going to go back to a larger code font, and some longer lines are OK? |
jwakely
added a commit
that referenced
this pull request
Apr 14, 2015
Consistency cleanups in [containers]: Whitespace
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses Issue #400
This part of the clean-up changes only whitespace
foo<A,B>becomesfoo<A, B>eraseandswap)