Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[class.pre] Fix incorrect comment in example #4624

Merged
merged 1 commit into from Jun 18, 2021
Merged

Conversation

jensmaurer
Copy link
Member

Partially addresses #4592

@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 17, 2021

@opensdh: could you please take a look?

@opensdh
Copy link
Contributor

opensdh commented Jun 17, 2021

I commented on the issue already.

@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 17, 2021

@opensdh: OK, thanks! So we take this PR as a partial improvement, but I'll leave it to you (= collectively) to come up with a more comprehensive example?

@opensdh
Copy link
Contributor

opensdh commented Jun 18, 2021

If it's up to me, we'd make the full change I suggested in one go, since @xmh0511 correctly pointed out that merely correcting the example leaves it a bit mysterious (apparently misplaced). I can always do the rest later, though, since some more work is already needed (as also noted).

@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 18, 2021

Thanks. I agree that we should get the full rewrite, but let's take this partial fix for now so that we're at least not saying anything wrong, even if it's mysterious. But I continue looking forward to the full solution!

@tkoeppe tkoeppe merged commit b6e0848 into cplusplus:master Jun 18, 2021
@jensmaurer jensmaurer deleted the c9 branch November 9, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants