Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[range.prim.data] Use ranges::begin(t) not ranges::begin(E) #4628

Merged
merged 1 commit into from Jun 17, 2021
Merged

[range.prim.data] Use ranges::begin(t) not ranges::begin(E) #4628

merged 1 commit into from Jun 17, 2021

Conversation

jwakely
Copy link
Member

@jwakely jwakely commented Jun 4, 2021

This is consistent with the typo fixes for ranges::size done in
aa9c660 as part of #3752.

@jwakely
[range.prim.data] Use ranges::begin(t) not ranges::begin(E)
185d8ad 
This is consistent with the typo fixes for ranges::size done in
aa9c660 as part of cplusplus#3752.
@jwakely jwakely mentioned this pull request Jun 4, 2021
Merged
@jwakely
Copy link
Member Author

jwakely commented Jun 4, 2021

As I said at #3752 (comment)

We check that ranges::begin(t) is valid, and then do ranges::begin(E) instead. It should have the same effects, but it's inconsistent and confusing to switch between t and E.

@jwakely jwakely requested a review from CaseyCarter June 4, 2021 11:37
CaseyCarter
CaseyCarter approved these changes Jun 4, 2021
View reviewed changes
Copy link
Contributor

@CaseyCarter CaseyCarter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea why I didn't make this change in P2091 - it seems like an obvious consistency fix.

@tkoeppe tkoeppe merged commit 20b9249 into cplusplus:master Jun 17, 2021
@jwakely jwakely deleted the ranges-data branch June 18, 2021 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jwakely @CaseyCarter @jensmaurer @tkoeppe