P1659R3 starts_with and ends_with #4674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohelEGP
suggested changes
Jun 9, 2021
jensmaurer
force-pushed
the
motions-2021-06-lwg-10
branch
from
d27d9f7
to
a2f0bc4
Compare
|
@JohelEGP , thanks, fixed. |
tkoeppe
force-pushed
the
motions-2021-06-lwg-10
branch
from
a2f0bc4
to
9418a95
Compare
tkoeppe
reviewed
Jun 16, 2021
Comment on lines
+4261
to
+4265
| template<@\libconcept{input_range}@ R1, @\libconcept{input_range}@ R2, class Pred = ranges::equal_to, class Proj1 = identity, | ||
| class Proj2 = identity> | ||
| requires @\libconcept{indirectly_comparable}@<iterator_t<R1>, iterator_t<R2>, Pred, Proj1, Proj2> | ||
| constexpr bool ranges::starts_with(R1&& r1, R2&& r2, Pred pred = {}, | ||
| Proj1 proj1 = {}, Proj2 proj2 = {}); |
There was a problem hiding this comment.
@jwakely: I'm not sure why this second overload doesn't have a specification, but that's what's in the paper. Please let me know if anything is missing here (or if this is covered by some blanket wording elsewhere).
There was a problem hiding this comment.
The range overloads map to the first/last overloads per [algorithms.requirements] p14.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4647
Fixes cplusplus/papers#442