P1989R2 Range constructor for std::string_view 2: Constrain Harder #4676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See http://lists.isocpp.org/lib/2021/06/19670.php for a glitch in the incoming paper. @tkoeppe , should this be fixed editorially? |
JohelEGP
suggested changes
Jun 9, 2021
jensmaurer
force-pushed
the
motions-2021-06-lwg-12
branch
from
6b61cec
to
c9d6b22
Compare
|
@JohelEGP , thanks, fixed. |
2 tasks
tkoeppe
force-pushed
the
motions-2021-06-lwg-12
branch
from
c9d6b22
to
d447003
Compare
The reference removal was omitted from P1989R2 accidentally. Without it, the entire constraint item would not apply when R is a reference type, even though it was clearly intended to cover that case.
|
@jensmaurer: yes, I'll assume that's fine and will add a fix. I've asked for LWG approval (@jwakely?), but will proceed assuming we'll get that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4649
Fixes cplusplus/papers#714