P2216R3 std::format improvements #4680
Conversation
jensmaurer
force-pushed
the
motions-2021-06-lwg-16
branch
from
b2b98e7
to
63cec7d
Compare
|
@JohelEGP , thanks, fixed. |
tkoeppe
force-pushed
the
motions-2021-06-lwg-16
branch
from
63cec7d
to
5f18ece
Compare
|
@jensmaurer: your commit message indicates that you didn't want to italicize the exposition-only If so, I'm going to open a new issue to do this later. We should also rename |
tkoeppe
force-pushed
the
motions-2021-06-lwg-16
branch
from
5f18ece
to
135e409
Compare
- Avoid redundantly presenting the definition of basic-format-string in the header synopsis. - Add dedicated section format.fmt.string for basic-format-string, instead of including it in fmt.error.report. - Reconcile with the earlier adoption of LWG-3539.
tkoeppe
force-pushed
the
motions-2021-06-lwg-16
branch
from
135e409
to
4126c12
Compare
I noted that the comment was right before a rebase. |
|
|
||
| template<class Out> | ||
| Out vformat_to(Out out, string_view fmt, | ||
| format_args_t<type_identity_t<Out>, char> args); | ||
| Out vformat_to(Out out, string_view fmt, format_args, args); |
There was a problem hiding this comment.
Extra comma in format_args, args
There was a problem hiding this comment.
fixed in linked pull request
| template<class Out> | ||
| Out vformat_to(Out out, wstring_view fmt, | ||
| format_args_t<type_identity_t<Out>, wchar_t> args); | ||
| Out vformat_to(Out out, wstring_view fmt, wformat_args, args); |
There was a problem hiding this comment.
Extra comma in wformat_args, args
There was a problem hiding this comment.
fixed in linked pull request
in the header synopsis.
consistent with similar situations.
Fixes #4653
Fixes cplusplus/papers#919