Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2325R3 Views should not be required to be default constructible #4683

Merged
merged 1 commit into from Jun 17, 2021
Merged

P2325R3 Views should not be required to be default constructible #4683

merged 1 commit into from Jun 17, 2021

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer commented Jun 10, 2021 •
edited

Also fixes LWG3479.

Fixes #4656
Fixes cplusplus/papers#1007

@jensmaurer jensmaurer added this to the post-2021-06 milestone Jun 10, 2021
@jensmaurer @tkoeppe
P2325R3 Views should not be required to be default constructible
479c6a8 
Also fixes LWG3479.

 - Conflicts addressed by assuming P2328R0 was applied.
 - Used non-propagating-cache for split_view.
@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 17, 2021

@jensmaurer: what was the reason for using "non-propagating-cache for split_view" (for the report)?

@tkoeppe tkoeppe merged commit 687a046 into master Jun 17, 2021
@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 17, 2021

@jensmaurer: Oh, I see, you changed optional<iterator_t<...>> to non-propagating-cache<iterator_t<...>>, because of Motion 18. And there's even an editor's note to do so.

@jensmaurer
Copy link
Member Author

Yes.

@jensmaurer jensmaurer deleted the motions-2021-06-lwg-19 branch October 21, 2021 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2021-06
2 participants
@jensmaurer @tkoeppe