Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2210R2 Superior String Splitting #4684

Merged
merged 2 commits into from Jun 17, 2021
Merged

P2210R2 Superior String Splitting #4684

merged 2 commits into from Jun 17, 2021

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer commented Jun 10, 2021 •
edited

Also fixes LWG3478.

Fixes #4657
Fixes cplusplus/papers#912

@jensmaurer jensmaurer added this to the post-2021-06 milestone Jun 10, 2021
JohelEGP
JohelEGP suggested changes Jun 10, 2021
View reviewed changes
source/ranges.tex Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
@jensmaurer
Copy link
Member Author

@JohelEGP , thanks, fixed.

JohelEGP
JohelEGP suggested changes Jun 13, 2021
View reviewed changes
source/ranges.tex Outdated Show resolved Hide resolved
source/ranges.tex Outdated Show resolved Hide resolved
@jensmaurer
Copy link
Member Author

@JohelEGP , thanks and applied.

@tkoeppe tkoeppe force-pushed the motions-2021-06-lwg-20 branch 2 times, most recently from cad7d11 to bc9b805 Compare June 17, 2021 15:20
timsong-cpp
timsong-cpp reviewed Jun 17, 2021
View reviewed changes
source/ranges.tex Outdated Show resolved Hide resolved
@tkoeppe tkoeppe force-pushed the motions-2021-06-lwg-20 branch 2 times, most recently from bae76bb to 69d9e58 Compare June 17, 2021 16:43
jensmaurer and others added 2 commits June 17, 2021 17:55
@jensmaurer @tkoeppe
P2210R2 Superior String Splitting
22de07a 
Also fixes LWG3478.
@tkoeppe
[range.lazy.split.inner] Fix "base()" according to LWG3533
eccd39d 
This is a follow-up to LWG3533 ("Consistency for `base() const &`"),
which changes lazy_split_view::inner-iterator::base's return type
and requires-clause.
@tkoeppe tkoeppe merged commit fc053d1 into master Jun 17, 2021
@jensmaurer jensmaurer deleted the motions-2021-06-lwg-20 branch October 21, 2021 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely left review comments

@tkoeppe tkoeppe tkoeppe left review comments

@timsong-cpp timsong-cpp timsong-cpp left review comments

@JohelEGP JohelEGP JohelEGP requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2021-06
Development

Successfully merging this pull request may close these issues.

[2021-06 LWG Motion 20] P2210R2 Superior String Splitting P2210 Superior String Splitting
5 participants
@jensmaurer @jwakely @tkoeppe @timsong-cpp @JohelEGP