Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider spanstream assignment operations #4700

Closed
tkoeppe opened this issue Jun 16, 2021 · 6 comments · Fixed by #5102
Closed

Consider spanstream assignment operations #4700

tkoeppe opened this issue Jun 16, 2021 · 6 comments · Fixed by #5102
Assignees
@jensmaurer

Comments

@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 16, 2021

See discussion in #4687: spanstream has a section "Assignment and swap", but only defines swap operations. Should assignment operations be defined, or at least defaulted? This applies to all of spanstream, ospanstream and ispanstream.
@tkoeppe tkoeppe mentioned this issue Jun 16, 2021
Merged
@JohelEGP
Copy link
Contributor

And basic_istringstream, see #4687 (comment).

@timsong-cpp
Copy link
Contributor

The intent is that assignment is entirely specified by [functions.within.classes].

@jwakely
Copy link
Member

jwakely commented Jun 17, 2021

Right, they are defined by front matter. They don't have any special behaviour that needs to be specified explicitly.

@jensmaurer
Copy link
Member

@tkoeppe: What's the remaining issue here, given [functions.within.classes] ?

@JohelEGP
Copy link
Contributor

That'd be making sure the subclause name and stable id mention swap and not assign.

@tkoeppe
Copy link
Contributor Author

tkoeppe commented Jun 18, 2021

@jensmaurer: Yes, what Johel said, we may want to rename the subclause heading.

@jensmaurer jensmaurer self-assigned this Nov 10, 2021
@jensmaurer jensmaurer mentioned this issue Nov 11, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jensmaurer jensmaurer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[input.output] Fix headings of 'assign and swap' subclauses jensmaurer/draft
5 participants
@jwakely @tkoeppe @timsong-cpp @JohelEGP @jensmaurer