New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing "<condition> is true
|false
"
#4713
Comments
TL;DR: In my opinion, adding "is
|
Recently, we have preferred " |
" |
But when it appears in code, it's an expression that may or may not be true. Otherwise, the third operand of The core of the issue is that [structure.requirements] p4 says "Requirements are stated in terms of well-defined expressions that define valid terms of the types that meet the requirements." So if the spec just says "Preconditions:
We could consider blanket wording that says when we use a conditional-expression in a Constraints:, Mandates:, or Preconditions: element, that we mean it has to be true. If we say that's what it means, then that's what it means. The problem is that today we don't say it, so we need the explicit "is If we don't add something saying that, then I think we do need to add the missing "is |
Oh… 🤔 Ok, I get it now. (Took time)
Ok, I underestimated the gravity of the situation. I'll agree with “is” if everyone believes “is” is fine. What is is is urgent 😎 |
[structure.specifications]/3.3 says that "Preconditions" specify "the conditions that the function assumes to hold whenever it is called; violation of any preconditions results in undefined behavior." If |
It may be that expressions involving Yes, we could have blanket wording, but blanket wording comes at a price, too, and I'm not convinced it would improve matters here. |
That's lengthy.
We want to avoid "shall" because it makes for worse overall reading pleasure. So, "shall be" -> "is", and we are at the status quo. |
Editorial meeting consensus: We would like to adopt the "is |
In [utilities]. we say things like "
get() == nullptr
." a lot instead of "get() == nullptr
istrue
." in many places.We should decide whether we want to demand a specific style, and if so, document that style and fix the existing text.
The text was updated successfully, but these errors were encountered: