Better string splitting example #4714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohelEGP
reviewed
Jun 22, 2021
With the adoption of P1989, string_view is constructible from subrange, we can use that to provide a good example of string splitting.
cor3ntin
force-pushed
the
corentin/split_string_view
branch
from
5a03c48
to
4775b56
Compare
jwakely
approved these changes
Jun 22, 2021
|
Thank you! For future reference, please try to prefix commit messages with the label of the affected subclause(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the adoption of P1989, string_view is constructible from
subrange, we can use that to provide a good example of
string splitting.