Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lib] Remove space between requires and parameter list #4719

Merged
merged 1 commit into from Jun 25, 2021
Merged

[lib] Remove space between requires and parameter list #4719

merged 1 commit into from Jun 25, 2021

Conversation

JohelEGP
Copy link
Contributor

Or

[concept.booleantestable,reverse.iter.elem,common.iter.nav] Remove space between requires and parameter list

@tkoeppe tkoeppe merged commit 264e536 into cplusplus:main Jun 25, 2021
@jensmaurer jensmaurer mentioned this pull request Jun 25, 2021
Open
@jensmaurer
Copy link
Member

I think we should decide first whether we want to go there or not. The existing practice does not show an obvious preference; see #4720.

@JohelEGP JohelEGP deleted the lib-requires-parameter-list branch June 25, 2021 22:22
@JohelEGP
Copy link
Contributor Author

JohelEGP commented Jun 25, 2021 •
edited

Right. I forgot about that Hahaha, so it's a new issue. Although there are not many _requires-expression_s with a parameter list on the library side in total, I noticed the minority fixed on this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaseyCarter CaseyCarter CaseyCarter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JohelEGP @jensmaurer @CaseyCarter @tkoeppe