Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notes due to TBAA and use "implementation" instead of "compiler" #4773

Closed
wants to merge 11 commits into from

Conversation

frederick-vs-ja
Copy link
Contributor

Fixes #4701.

I'm not sure whether the "compiler" in "compiler optimization", "compiler transformation" etc. can be replaced with "implementation".

timsong-cpp and others added 10 commits July 21, 2021 10:47
…4732)

A new note explains that `emplace-deref` does not require materialization
of the result of `*i` before the initialization. The normatively expressed
requirement in terms of an invented initialization of a variable was prone
to confusion, since such a declaration would indeed require `*i` to be
copyable/movable, whereas the actual use of `emplace-deref` does not
cause any intermediate materializations of prvalues.
…his object"

Avoid saying "this object" when not talking about `*this`.
…re accurately

Class templates are not types. Function templates are not function signatures.
The definition of 'common initial sequence' in [class.mem] only applies
to standard-layout struct types, which excludes unions. There is no
reason to define is_corresponding_member in terms of standard-layout
types (which includes unions and scalars and arrays of such types) when
the common initial sequence is only meaningful for standard-layout
structs.
The former includes names introduced by alias-declarations,
the latter (arguably) does not.
@tkoeppe
Copy link
Contributor

tkoeppe commented Jul 28, 2021

Could you kindly rebase this? I had to force-push the main branch. Thanks!

@jensmaurer jensmaurer added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Jul 28, 2021
@jensmaurer
Copy link
Member

@frederick-vs-ja , we're sorry, but this seems to need another rebase / force-push. Please do not create merge commits; just rebase, fix the fall-out and force-push.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase The pull request needs a git rebase to resolve merge conflicts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[out.ptr.t][inout.ptr.t] The notes for operator void** might suggest violation of the strict aliasing rule
6 participants