Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[basic.types.general] Fix comment in example #4783

Merged
merged 1 commit into from Jul 28, 2021
Merged

[basic.types.general] Fix comment in example #4783

merged 1 commit into from Jul 28, 2021

Conversation

jensmaurer
Copy link
Member

Fixes #4779

@tkoeppe
Copy link
Contributor

tkoeppe commented Jul 28, 2021

@jensmaurer: could you kindly rebase this after my force-push? (And any other branches you may have?)

@jensmaurer
Copy link
Member Author

Done.

"And any other branches you may have?"

That's a joke, right? Feel free to tag with "needs-rebase" any that you encounter.

@tkoeppe
Copy link
Contributor

tkoeppe commented Jul 28, 2021

Only those PRs that are based on a later commit than where I force-pushed should be affected, so I was hoping there wouldn't be too many!

@jensmaurer
Copy link
Member Author

Ok, let's pretend those have been handled.

@jensmaurer jensmaurer requested a review from tkoeppe July 28, 2021 19:25
@tkoeppe tkoeppe merged commit 7ce2694 into cplusplus:main Jul 28, 2021
@jensmaurer jensmaurer deleted the c13 branch July 28, 2021 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe Awaiting requested review from tkoeppe

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[basic.types.general] p6 Incorrect comment in example
2 participants
@jensmaurer @tkoeppe