[lex, dcl.decl] Use \nontermdef and \grammarterm more consistently. #481
Conversation
|
Could you please amend the commit to start the commit message with the affected clauses/secions? Like |
Oxyd
changed the title
|
I'm not sure if I did this correctly, but it looks amended to me now. If not, I can create a new pull request with proper commit message. |
|
This looks good, thanks! |
|
@zygoloid: PTAL? |
| @@ -1370,7 +1370,7 @@ | |||
|
|
|||
| \pnum | |||
| \enternote A source-file new-line in a raw string literal results in a new-line in the | |||
| resulting execution \term{string-literal}. Assuming no | |||
| resulting execution \grammarterm{string-literal}. Assuming no | |||
There was a problem hiding this comment.
This should be "string literal", not "\grammarterm{...}" nor "\term{...}", because it's talking about the string literal object, not the element of the grammar.
There was a problem hiding this comment.
@Oxyd: Could you please revise and rebase?
There was a problem hiding this comment.
@zygoloid: Since you have push access, can you not make the change yourself directly in github?
There was a problem hiding this comment.
@tkoeppe It looks like I'd need push access to Oxyd/draft for that.
There was a problem hiding this comment.
@zygoloid: Ah, so that's what that means. I thought you could somehow edit the change in flight, but obviously that doesn't make any sense. Never mind then, we'll wait for the OP to edit his branch.
There was a problem hiding this comment.
@Oxyd: I think zygoloid asked for "string literal", not "string-literal".
|
@Oxyd: please take another look. |
|
@tkoeppe Okay, changed "string-literal" to "string literal". |
|
Thank you. @zygoloid: This looks ready. |
[lex, dcl.decl] Use \nontermdef and \grammarterm more consistently.
No description provided.