New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix several index entries. #483
Conversation
1454ecd
to
bc8ffd9
Compare
@@ -28,7 +28,7 @@ | |||
\indextext{conventions!lexical|(}% | |||
\indextext{compilation!separate|(}% | |||
The text of the program is kept in units called | |||
\indextext{source file}\term{source files} in this International | |||
\defnx{source files}{source file} in this International |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
\defn{source file}{s} perhaps?
The diffs look good to me, thanks. @tkoeppe Would you mind looking over the built standard to double-check? |
\index{grammar}% | ||
\index{summary, syntax}% | ||
\indextext{grammar}% | ||
\indextext{summary, syntax}% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this is summary, syntax
rather than summary!syntax
?
Generally a good change. Two nitpicks, see above. The change replaces the low-level |
Thanks for the review and suggestions! I've re-pushed the branch with amended commits fixing the issues. |
The changes look good! |
Ah, thanks, I'll look into it. |
…the one in [expr.unary.op].
It was simply because [except.ctor]p1 actually defines "stack unwinding" as a term with a proper index entry. So there is no need for a "see" index entry for stack unwinding in the first place. :) I've amended the commit that tried to fix that "see" index entry, to no longer try to fix it, and added a separate commit to remove it. |
Sounds good, thanks! @zygoloid: I think this is ready for merging. |
@@ -2,7 +2,7 @@ | |||
\rSec0[intro]{General} | |||
|
|||
\indextext{diagnostic message|see{message, diagnostic}}% | |||
\indexdefn{conditionally-supported behavior!see{behavior, conditionally-supported}}% | |||
\indexdefn{conditionally-supported behavior|see{behavior, conditionally-supported}}% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When to use indexdefn vs. indextext? Looking in macros.tex, they seem to be equivalent.
Currently, yes, but indexdefn has more semantic meaning, and could in theory be formatted differently in future. |
No description provided.