Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synopsis in [support.exception] gives no clue that uncaught_exception() is in [depr.uncaught] #485

Closed
jwakely opened this issue Apr 28, 2015 · 3 comments
Closed

Synopsis in [support.exception] gives no clue that uncaught_exception() is in [depr.uncaught] #485

jwakely opened this issue Apr 28, 2015 · 3 comments
Labels
tiny An issue with a small change; with "cwg" label: can be applied editorially after CWG consent.

Comments

@jwakely
Copy link
Member

jwakely commented Apr 28, 2015

There should be a cross-reference from the synopsis to "D.9, uncaught_exception (deprecated)"

Also [ostream::sentry] still uses the deprecated version, it should be updated to use uncaught_exceptions()
@jwakely jwakely added the tiny An issue with a small change; with "cwg" label: can be applied editorially after CWG consent. label Apr 28, 2015
@jwakely
Copy link
Member Author

jwakely commented Apr 28, 2015

Fixed at eb009db

@jwakely jwakely closed this as completed Apr 28, 2015
@cpplearner
Copy link
Contributor

I think [ostream::sentry] could use uncaught_exceptions() more cleverly, i.e. store uncaught_exceptions() on construction, and during the destruction, compare uncaught_exceptions() with the stored value, then decide whether it should call os.rdbuf()->pubsync() based on the result of the comparison, instead of on !uncaught_exceptions().

@jwakely
Copy link
Member Author

jwakely commented Apr 28, 2015

That would not be an editorial change, so doesn't belong in this issues list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tiny An issue with a small change; with "cwg" label: can be applied editorially after CWG consent.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwakely @cpplearner