Grammatical improvement; NFC intended #486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but should it also be "like a non-explicit-constructor" rather than "like non-explicit-constructors" ? |
|
That seems like a reasonable suggestion. I'll make that change as well. Thanks! |
|
Uncertain if I did the correct git dance, but I think this pull request now contains both of my modification. If not, I can try again. :-) |
|
We have an in-flight core issue that modifies this wording (http://wiki.edg.com/twiki/pub/Wg21lenexa/DraftingReviewTeleconference2015-04-06/proposed_resolution_core-1978.html); I'd like to defer this change until after it lands. |
|
Works for me! We can figure out what to do in Lenexa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is an editorial improvement to the wording, but if it's not editorial, or if I've mucked something up, please let me know.