[expr.ass] Clarify type of assignment-expression #4865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please add a tiny bit of motivation/background to a second paragraph in the commit message, as discussed in the linked issue? Then feel free to commit. Thanks! |
An expression has a type and a value category. This particular compound-expression was missing the specification of its (result) type.
|
@tkoeppe: better? |
|
Yes, nice, thanks! |
|
So, nobody cares about "result" misuse? |
Comment on lines
6841
to
+6842
| require a modifiable lvalue as their left operand; their result is an lvalue | ||
| referring to the left operand. The result in all cases is a bit-field if | ||
| of the type of the left operand, referring to the left operand. The result in all cases is a bit-field if |
There was a problem hiding this comment.
Suggested change
| require a modifiable lvalue as their left operand; their result is an lvalue | |
| referring to the left operand. The result in all cases is a bit-field if | |
| of the type of the left operand, referring to the left operand. The result in all cases is a bit-field if | |
| require a modifiable lvalue as their left operand; they are lvalues | |
| of the type of the left operand, denoting the result of the left operand. The result in all cases is a bit-field if |
mebby this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4864