Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qualify move & forward with std:: #489

Closed
wants to merge 1 commit into from

Conversation

lichray
Copy link
Contributor

@lichray lichray commented May 5, 2015

Please check PDF output to ensure that the table is not messed up.

@jwakely jwakely self-assigned this May 5, 2015
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 17, 2015

Could you please add the section or file reference to the commit message? Take a look how other commits are labelled.

@lichray
Copy link
Contributor Author

lichray commented Nov 17, 2015

The changes happen to be in one file but actually this change is applied globally. The title matches the intention.

@jwakely
Copy link
Member

jwakely commented Nov 18, 2015

Thanks, applied partially as 4d69bcb

Qualifying std::forward isn't necessary because the template argument list prevents ADL (although I always get confused by the specifics of that rule).

@jwakely jwakely closed this Nov 18, 2015
@timsong-cpp
Copy link
Contributor

because the template argument list prevents ADL

It doesn't. ADL takes place as normal for meow<T>(stuff), as long as ordinary unqualified lookup finds a function template named meow in scope so that the compiler knows how to parse the <.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants