Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[basic.life] Remove a partial repetition of the end-of-lifetime rules #4894

Merged
merged 6 commits into from
Oct 21, 2021
Merged

[basic.life] Remove a partial repetition of the end-of-lifetime rules #4894

merged 6 commits into from
Oct 21, 2021
+8 −10

Conversation

geryogam
Copy link
Contributor

@geryogam geryogam commented Sep 12, 2021 •
edited
Loading

Add in the first sentence of [basic.life]/5 that storage release also ends an object’s lifetime.

@jensmaurer
Copy link
Member

Please rebase to HEAD and force-push so that the automated test can run.

jensmaurer
jensmaurer approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with me.

@JohelEGP
Copy link
Contributor

Mind the https://github.com/cplusplus/draft/wiki/Commit-message-format.

@geryogam
Copy link
Contributor Author

Thanks for the suggestion. Done.

@geryogam
Copy link
Contributor Author

@jensmaurer

Please rebase to HEAD and force-push so that the automated test can run.

Done.

Fine with me.

Thanks for the review.

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 25, 2021

@zygoloid: could you please take a look? Lifetimes have become ever more complicated, so I want to make sure we're not stepping on any subtleties here.

zygoloid
zygoloid reviewed Sep 26, 2021
View reviewed changes
@geryogam geryogam requested a review from zygoloid September 27, 2021 07:08
@geryogam geryogam changed the title [basic.life] Storage release also ends an object’s lifetime [basic.life] Remove a repetition of the end-of-lifetime rules Sep 29, 2021
@geryogam geryogam changed the title [basic.life] Remove a repetition of the end-of-lifetime rules [basic.life] Remove a partial repetition of the end-of-lifetime rules Sep 29, 2021
languagelawyer
languagelawyer suggested changes Sep 30, 2021
View reviewed changes
zygoloid
zygoloid reviewed Oct 20, 2021
View reviewed changes
@jensmaurer jensmaurer added this to the post-2021-10 milestone Oct 21, 2021
@jensmaurer
Copy link
Member

Could you please squash all these commits and force-push?

zygoloid
zygoloid approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@zygoloid zygoloid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an improvement to me.

@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 21, 2021

Thanks!

@tkoeppe tkoeppe merged commit 23b36a4 into cplusplus:main Oct 21, 2021
@geryogam geryogam deleted the patch-2 branch October 21, 2021 17:07
@geryogam
Copy link
Contributor Author

Thank you all for the review.

@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 21, 2021

@maggyero And thanks for the cleanup!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe

@languagelawyer languagelawyer

@zygoloid zygoloid

@jensmaurer jensmaurer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2021-10
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@geryogam @jensmaurer @JohelEGP @tkoeppe @zygoloid @languagelawyer