Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lex.phases] p2 Any Splice's deleting is firstly taken place CWG2747 #4903

Open
xmh0511 opened this issue Sep 14, 2021 · 2 comments
Open

[lex.phases] p2 Any Splice's deleting is firstly taken place CWG2747 #4903

xmh0511 opened this issue Sep 14, 2021 · 2 comments
Labels
cwg Issue must be reviewed by CWG. not-editorial Issue is not deemed editorial; the editorial issue is kept open for tracking.

Comments

@xmh0511
Copy link
Contributor

xmh0511 commented Sep 14, 2021

[lex.phases] p2

Each sequence of a backslash character () immediately followed by zero or more whitespace characters other than new-line followed by a new-line character is deleted, splicing physical source lines to form logical source lines. Only the last backslash on any physical source line shall be eligible for being part of such a splice. Except for splices reverted in a raw string literal, if a splice results in a character sequence that matches the syntax of a universal-character-name, the behavior is undefined. A source file that is not empty and that does not end in a new-line character, or that ends in a splice, shall be processed as if an additional new-line character were appended to the file.

"splice" is newly introduced by p2223r2. Presumably, it refers to any sequence of a backslash character ( \ ) immediately followed by zero or more whitespace characters other than new-line followed by a new-line character? However, as the above rule specified, any such sequence is deleted firstly, which takes place prior to the emphasized part. Should we say

A source file that is not empty and that does not end in a new-line character, or that ends in a splice before any such splicing takes place, shall be processed as if an additional new-line character were appended to the file.

@xmh0511 xmh0511 changed the title [lex.phases] p2 Splice deleting is firstly taken place [lex.phases] p2 Any Splice's deleting is firstly taken place Sep 15, 2021
@jensmaurer jensmaurer added decision-required A decision of the editorial group (or the Project Editor) is required. cwg Issue must be reviewed by CWG. labels Oct 21, 2021
@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 12, 2023

Editorial meeting consensus: It's true that "splice" refers to the combination of backslash and newline being processed, which we don't have here. Suggestion: Replace "ends in a splice" with "ends in a backslash", which is what we really mean.

@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Jun 12, 2023
@jensmaurer
Copy link
Member

CWG2747

@jensmaurer jensmaurer changed the title [lex.phases] p2 Any Splice's deleting is firstly taken place [lex.phases] p2 Any Splice's deleting is firstly taken place CWG2747 Jun 13, 2023
@jensmaurer jensmaurer added the not-editorial Issue is not deemed editorial; the editorial issue is kept open for tracking. label Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cwg Issue must be reviewed by CWG. not-editorial Issue is not deemed editorial; the editorial issue is kept open for tracking.
Projects
None yet
Development

No branches or pull requests

3 participants