Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dcl.init.general] break p7 into three paragraphs #4912

Merged
merged 1 commit into from Sep 16, 2021
Merged

[dcl.init.general] break p7 into three paragraphs #4912

merged 1 commit into from Sep 16, 2021

Conversation

jwakely
Copy link
Member

@jwakely jwakely commented Sep 16, 2021 •
edited

Is [dcl.init.general] p7 really supposed to be all one paragraph, with bullet numbers continuing between two separate lists, or should there be a \pnum after each list? Or just after the first list, giving two paragraphs?

@JohelEGP
Copy link
Contributor

That looks better. The stable name should be [dcl.init.general].

@jwakely jwakely changed the title [dcl.init] break p7 into three paragraphs [dcl.init.general] break p7 into three paragraphs Sep 16, 2021
@jwakely
Copy link
Member Author

jwakely commented Sep 16, 2021

The stable name should be [dcl.init.general].

Oops, fixed, thanks!

@jensmaurer
Copy link
Member

I agree with the addition of the first \pnum, but the second one seems not an improvement.
We're directly using the term "const-default-constructible" that we've introduced just before, and I'm generally dubious of introducing single-sentence paragraphs unless the subject matter is clearly different. Here, it is not.

@jwakely , if you would be so kind to revert the second \pnum; I'd then apply this as an obvious editorial improvement on the typo level. @tkoeppe , any thoughts here?

@jwakely
Copy link
Member Author

jwakely commented Sep 16, 2021

Will do

@jwakely
Copy link
Member Author

jwakely commented Sep 16, 2021

Done!

@jensmaurer
Copy link
Member

Thanks!

@jensmaurer jensmaurer merged commit dc5a7d6 into cplusplus:main Sep 16, 2021
@jwakely jwakely deleted the definit branch September 16, 2021 19:29
@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 17, 2021

Looks good, thanks. I would probably also have got rid of the source blank lines around the itemizes, so that the source code visual structure reflects the \pnums, but we have a lot of historic ballast there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jensmaurer jensmaurer jensmaurer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jwakely @JohelEGP @jensmaurer @tkoeppe