Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[basic.lval] Replace the misused term ‘classifications’ by ‘categories’ #4913

Merged
merged 2 commits into from Jun 13, 2023

Conversation

geryogam
Copy link
Contributor

A single classification/categorization is a set of classes/categories.

A single classification/categorization is a set of classes/categories.
@jensmaurer jensmaurer added the decision-required A decision of the editorial group (or the Project Editor) is required. label Oct 24, 2021
@tkoeppe
Copy link
Contributor

tkoeppe commented Nov 19, 2021

I'm tempted to agree that this is an improvement, but just out of an abundance of caution, could we get CWG's approval?

@tkoeppe tkoeppe added the cwg Issue must be reviewed by CWG. label Nov 19, 2021
@jensmaurer jensmaurer removed the decision-required A decision of the editorial group (or the Project Editor) is required. label Jun 12, 2023
@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 12, 2023

Side note: There is one more use of the word "classifications" in the text, in concepts.tex, but that is unrelated ("These concepts express relationships between types, type classifications, and fundamental type properties.")

source/expressions.tex Outdated Show resolved Hide resolved
Copy link
Member

@jensmaurer jensmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CWG 2023-06-13: Approved in general, with one change requested.

Co-authored-by: Jens Maurer <Jens.Maurer@gmx.net>
@tkoeppe tkoeppe requested a review from jensmaurer June 13, 2023 15:57
@tkoeppe tkoeppe merged commit 3dc682c into cplusplus:main Jun 13, 2023
2 checks passed
@geryogam geryogam deleted the patch-3 branch June 13, 2023 16:38
@geryogam
Copy link
Contributor Author

Thanks for the review @tkoeppe and @jensmaurer!

@tkoeppe
Copy link
Contributor

tkoeppe commented Jun 13, 2023

You're most welcome, thank you for raising the issue :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cwg Issue must be reviewed by CWG.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants