Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[facet.num.get.virtuals] Two minor fixes: #4915

Closed
wants to merge 1 commit into from
Closed

[facet.num.get.virtuals] Two minor fixes: #4915

wants to merge 1 commit into from

Conversation

CaseyCarter
Copy link
Contributor

  • correct indentation in "as-if by" code for readability
  • use plural verb "are" with plural subject "positions"

@CaseyCarter
[facet.num.get.virtuals] Two minor fixes:
f974a47 
* correct indentation in "as-if by" code for readability
* use plural verb "are" with plural subject "positions"
@jensmaurer
Copy link
Member

Split into two separate commits 59478b9 and 6e20d2f and merged, thanks.

@jensmaurer jensmaurer closed this Sep 18, 2021
@CaseyCarter CaseyCarter deleted the tiny branch September 20, 2021 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CaseyCarter @jensmaurer @jwakely