Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[std] Replace \rSec with \subclause #4920

Closed
wants to merge 4 commits into from
Closed

[std] Replace \rSec with \subclause #4920

wants to merge 4 commits into from

Conversation

JohelEGP
Copy link
Contributor

Resolves #3352.

1632094285

@JohelEGP
Copy link
Contributor Author

Should \rSec be retired by this PR? There are some diff macros. Those are not used by the standard, but are used to write proposals. In that sense, retiring it would be an API break.

@JohelEGP JohelEGP changed the title [std] Replace \rSec with \clause and \subclase [std] Replace \rSec with \subclase Sep 21, 2021
@jensmaurer jensmaurer changed the title [std] Replace \rSec with \subclase [std] Replace \rSec with \subclause Sep 22, 2021
@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 25, 2021

Thanks for this suggestion. We would prefer to generate these changes ourselves; have you got a set of instructions or a script to generate them by any chance?

@JohelEGP
Copy link
Contributor Author

Patch macros.tex:

diff --git a/source/macros.tex b/source/macros.tex
index ca967458..650db4c3 100644
--- a/source/macros.tex
+++ b/source/macros.tex
@@ -102,6 +102,8 @@
 \s[#3]{#3\hfill[#2]}\l{#2}\addxref{#2}%
 }
 
+\def\subclause#1[#2]#3{\Sec#1[#2]{#3}}
+
 % A convenience feature (mostly for the convenience of the Project
 % Editor, to make it easy to move around large blocks of text):
 % the \rSec macro is just like the \Sec macro, except that depths

Then run

sed -i 's/^\\rSec/\\subclause/' source/*.tex
sed -i 's/rSec/subclause/g' tools/* .ctags

@tkoeppe
Copy link
Contributor

tkoeppe commented Sep 25, 2021

Thanks!

@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Oct 24, 2021
@JohelEGP JohelEGP mentioned this pull request Nov 25, 2021
Open
@JohelEGP JohelEGP closed this Nov 25, 2021
@JohelEGP JohelEGP deleted the clause-macros branch November 25, 2021 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
needs rebase The pull request needs a git rebase to resolve merge conflicts.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[std] Replace \rSec with plain \Sec
3 participants
@JohelEGP @tkoeppe @wg21bot