New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[lib] Rename exposition-only 'no-throw-' concepts #4942
Conversation
for consistency with nothrow_constructible.
template<class R> | ||
concept @\exposconcept{no-throw-forward-range}@ = @\seebelow@; // \expos | ||
concept @\exposconcept{nothrow-forward-range}@ = @\seebelow@; // \expos |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems strange that you didn't have to readjust the comment to be aligned at a multiple of 4.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The checking machinery ignores lines with an @ in them, because they disconnect the source file indentation from the rendered indentation anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't the % macro length:
comments in macros.tex
for that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those came afterwards and are not reflected in the checking machinery.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If turns out that the alignment is actually locally consistent (but maybe not a factor-of-4), because all exposition-only concepts in the vicinity are of the nothrow-x kind. I'll not touch this for now until we actually get proper checking of @ widths.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine. Ultimately, the goal of the guidance is set us on an overall path of steady improvement, but there are still many parts of the text that don't follow it (or worse, contain italics), and it's not the end of the world. Thanks for spotting this, but also don't sweat it too much.
to 'nothrow-', for consistency with nothrow_constructible
Fixes #4101