Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lib] Rename exposition-only 'no-throw-' concepts #4942

Merged
merged 1 commit into from Sep 27, 2021

Conversation

jensmaurer
Copy link
Member

to 'nothrow-', for consistency with nothrow_constructible

Fixes #4101

for consistency with nothrow_constructible.
@jensmaurer jensmaurer merged commit 3a97ba6 into cplusplus:main Sep 27, 2021
template<class R>
concept @\exposconcept{no-throw-forward-range}@ = @\seebelow@; // \expos
concept @\exposconcept{nothrow-forward-range}@ = @\seebelow@; // \expos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems strange that you didn't have to readjust the comment to be aligned at a multiple of 4.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The checking machinery ignores lines with an @ in them, because they disconnect the source file indentation from the rendered indentation anyway.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't the % macro length: comments in macros.tex for that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those came afterwards and are not reflected in the checking machinery.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If turns out that the alignment is actually locally consistent (but maybe not a factor-of-4), because all exposition-only concepts in the vicinity are of the nothrow-x kind. I'll not touch this for now until we actually get proper checking of @ widths.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine. Ultimately, the goal of the guidance is set us on an overall path of steady improvement, but there are still many parts of the text that don't follow it (or worse, contain italics), and it's not the end of the world. Thanks for spotting this, but also don't sweat it too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[special.mem.concepts] Remove hyphen in _no-throw_ for consistency with the type traits
4 participants