Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2128R6 Multidimensional subscript operator #4997

Merged
merged 1 commit into from Oct 16, 2021
Merged

P2128R6 Multidimensional subscript operator #4997

merged 1 commit into from Oct 16, 2021

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer added this to the post-2021-10 milestone Oct 4, 2021
JohelEGP
JohelEGP suggested changes Oct 4, 2021
View reviewed changes
source/compatibility.tex Outdated Show resolved Hide resolved
@burblebee burblebee added the changes requested Changes to the wording or approach have been requested and not yet applied. label Oct 16, 2021
burblebee
burblebee previously requested changes Oct 16, 2021
View reviewed changes
source/compatibility.tex Outdated Show resolved Hide resolved
source/expressions.tex Outdated Show resolved Hide resolved
source/expressions.tex Show resolved Hide resolved
source/expressions.tex Outdated Show resolved Hide resolved
source/compatibility.tex Outdated Show resolved Hide resolved
@jensmaurer
Copy link
Member Author

jensmaurer commented Oct 16, 2021 •
edited

@tkoeppe , any further changes you want to have applied here?
The conflict in overloading.tex should be resolved by preferring "our" wording (this paper seeks to relax the one-parameter restriction of operator[]).

@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Oct 16, 2021
@tkoeppe tkoeppe dismissed burblebee’s stale review October 16, 2021 23:36

requested changes have been actioned, thanks!

@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 16, 2021

@jensmaurer: Yes, thanks, I came to the same conclusion! Merging now.

@tkoeppe tkoeppe merged commit 7921088 into main Oct 16, 2021
@jensmaurer jensmaurer mentioned this pull request Nov 30, 2021
Closed
@jensmaurer jensmaurer deleted the motions-2021-10-cwg-9 branch February 9, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkoeppe tkoeppe tkoeppe left review comments

@cpplearner cpplearner cpplearner left review comments

@Mick235711 Mick235711 Mick235711 left review comments

@JohelEGP JohelEGP JohelEGP requested changes

@burblebee burblebee burblebee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2021-10
Development

Successfully merging this pull request may close these issues.

[2021-10 CWG Motion 9] P2128R6 Multidimensional subscript operator P2128 Multidimensional subscript operator
6 participants
@jensmaurer @tkoeppe @burblebee @cpplearner @JohelEGP @Mick235711