Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2314R4 Character sets and encodings #5004

Merged
merged 4 commits into from Oct 18, 2021
Merged

P2314R4 Character sets and encodings #5004

merged 4 commits into from Oct 18, 2021

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer added this to the post-2021-10 milestone Oct 6, 2021
@hubert-reinterpretcast
Copy link
Contributor

@jensmaurer @jwakely, this is missing an editorial update of the cross-reference from [fs.path.type.cvt] for the term "execution wide-character set". The cross-reference should point to [character.seq] and not [lex.charset].

@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Oct 14, 2021
@jensmaurer
Copy link
Member Author

@hubert-reinterpretcast , fixed.

@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Oct 14, 2021
burblebee
burblebee requested changes Oct 16, 2021
View reviewed changes
source/basic.tex Outdated Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
source/lex.tex Show resolved Hide resolved
source/lex.tex Show resolved Hide resolved
source/lex.tex Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
source/lib-intro.tex Show resolved Hide resolved
source/compatibility.tex Show resolved Hide resolved
@jensmaurer jensmaurer added the changes requested Changes to the wording or approach have been requested and not yet applied. label Oct 16, 2021
jensmaurer
jensmaurer commented Oct 16, 2021
View reviewed changes
source/basic.tex Outdated Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
source/lex.tex Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
source/lex.tex Show resolved Hide resolved
source/lex.tex Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
source/lex.tex Outdated Show resolved Hide resolved
source/lib-intro.tex Show resolved Hide resolved
jensmaurer
jensmaurer commented Oct 16, 2021
View reviewed changes
source/lex.tex Outdated Show resolved Hide resolved
@jensmaurer jensmaurer force-pushed the motions-2021-10-cwg-10 branch 2 times, most recently from e112e88 to 82165dc Compare October 16, 2021 20:46
@jensmaurer
Copy link
Member Author

jensmaurer commented Oct 16, 2021 •
edited

@tkoeppe , please have a look what else you want to have addressed.
The conflict in preprocessor.tex should be resolved to prefer the "other" (shorter) wording.

@jensmaurer jensmaurer removed the changes requested Changes to the wording or approach have been requested and not yet applied. label Oct 16, 2021
@burblebee burblebee mentioned this pull request Oct 17, 2021
Closed
burblebee
burblebee approved these changes Oct 17, 2021
View reviewed changes
Copy link
Contributor

@burblebee burblebee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all those fixes!

tkoeppe
tkoeppe reviewed Oct 18, 2021
View reviewed changes
source/lib-intro.tex Outdated Show resolved Hide resolved
tkoeppe
tkoeppe reviewed Oct 18, 2021
View reviewed changes
source/lex.tex Outdated Show resolved Hide resolved
@tkoeppe
[lex.literals] Improve presentation of tables.
4fe9634 
Break lines better, and add horizontal rules (to make "rowspaning
cells") to clarify the scope of table entries.
@tkoeppe tkoeppe merged commit fd7b67f into main Oct 18, 2021
hubert-reinterpretcast
hubert-reinterpretcast reviewed Oct 19, 2021
View reviewed changes
source/lex.tex
\impldef{mapping physical source file characters to basic source character set} manner,
to the basic source character set (introducing new-line characters for end-of-line
indicators) if necessary.
\impldef{mapping physical source file characters to translation character set} manner,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jensmaurer, this is subtly different from the other cross-reference for the same concept (the other index entry has "mapping from" instead of just "mapping").

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created #5041.

@hubert-reinterpretcast hubert-reinterpretcast mentioned this pull request Oct 20, 2021
Closed
@jensmaurer jensmaurer deleted the motions-2021-10-cwg-10 branch February 9, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubert-reinterpretcast hubert-reinterpretcast hubert-reinterpretcast left review comments

@timsong-cpp timsong-cpp timsong-cpp left review comments

@JohelEGP JohelEGP JohelEGP left review comments

@tkoeppe tkoeppe tkoeppe approved these changes

@burblebee burblebee burblebee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2021-10
Development

Successfully merging this pull request may close these issues.

[2021-10 CWG Motion 10] P2314R4 Character sets and encodings P2314 Character sets and encodings
6 participants
@jensmaurer @hubert-reinterpretcast @tkoeppe @burblebee @timsong-cpp @JohelEGP