Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2418R2 Add support for std::generator-like types to std::format #5011

Merged
merged 2 commits into from Oct 18, 2021
Merged

P2418R2 Add support for std::generator-like types to std::format #5011

merged 2 commits into from Oct 18, 2021

Conversation

jensmaurer
Copy link
Member

@jensmaurer jensmaurer added this to the post-2021-10 milestone Oct 8, 2021
burblebee
burblebee requested changes Oct 16, 2021
View reviewed changes
source/utilities.tex Outdated Show resolved Hide resolved
source/compatibility.tex Outdated Show resolved Hide resolved
source/compatibility.tex Outdated Show resolved Hide resolved
source/compatibility.tex Outdated Show resolved Hide resolved
@jensmaurer jensmaurer added changes requested Changes to the wording or approach have been requested and not yet applied. and removed changes requested Changes to the wording or approach have been requested and not yet applied. labels Oct 16, 2021
@tkoeppe tkoeppe force-pushed the motions-2021-10-lwg-4 branch 2 times, most recently from d0a9ae2 to b82b5e2 Compare October 18, 2021 23:03
tkoeppe
tkoeppe reviewed Oct 18, 2021
View reviewed changes
source/utilities.tex Outdated
@@ -21544,7 +21583,8 @@
Context& format_ctx, const void* ptr) {
typename Context::template formatter_type<T> f;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing edit here, should say formatter_type<TD>? (I can fix that.)

@tkoeppe tkoeppe merged commit aaa2b06 into main Oct 18, 2021
JohelEGP
JohelEGP reviewed Oct 19, 2021
View reviewed changes
Copy link
Contributor

@JohelEGP JohelEGP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing edit:

Update the value of the feature-testing macro __cpp_lib_format to the date of adoption in [version.syn]:

Is this perhaps updated by another motion?

@jensmaurer
Copy link
Member Author

@JohelEGP , this is (luckily) covered by commit 582ec50:

P2372R3 Fixing locale handling in chrono formatters

In [time.zone.zonedtime.nonmembers], remove the separate
"Returns" item now that have "Effects: Equivalent to: return ..."

@jensmaurer jensmaurer deleted the motions-2021-10-lwg-4 branch July 29, 2022 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwakely jwakely jwakely left review comments

@tkoeppe tkoeppe tkoeppe left review comments

@timsong-cpp timsong-cpp timsong-cpp left review comments

@JohelEGP JohelEGP JohelEGP left review comments

@burblebee burblebee Awaiting requested review from burblebee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
post-2021-10
6 participants
@jensmaurer @jwakely @tkoeppe @burblebee @timsong-cpp @JohelEGP